refactor: refactor timestamp handling so tests in meeting app pass - #4371
Merged
jennifer-richards merged 44 commits intoAug 26, 2022
Merged
Conversation
datetime.datetime.today() is equivalent to datetime.datetime.now(); both return a naive datetime with the current local time.
This is effectively the same, but is less likely to encourage accidental use of naive datetimes.
Nearly all interim meetings on or before 2016-07-01 have blank time_zone values. This migration fills these in with PST8PDT.
All tests in meetings.tests_views now passing
(for me, anyway)
The django-celery-beat package introduces tables with timestamp columns. These columns are stored in CELERY_TIMEZONE. Because we run with this set to UTC, the migration ignores these columns.
# Conflicts: # ietf/meeting/management/commands/session_purpose_demo.py # ietf/meeting/models.py # ietf/meeting/tests_views.py # ietf/meeting/views.py
# Conflicts: # ietf/meeting/models.py
jennifer-richards
marked this pull request as ready for review
August 26, 2022 16:08
rjsparks
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests in ietf.meeting pass. Have not yet looked at diffs of real pages.