fix: removal of deleted or changed registrations#4359
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Aug 25, 2022
Merged
fix: removal of deleted or changed registrations#4359rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
…tions get removed from MeetingRegistrations
rjsparks
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At end of get_meeting_registration_data() any records in meeting_registrations represent deleted or changed registrations that should be removed from the table. When limiting removal to 5 records, if more than 5 registrations were deleted or switched from onsite<->remote, or vice-verse, in one day, than all subsequent removals would fail.