Skip to content

fix: allow 90m session requests. Prompt for cannot meet at time reasoning.#4345

Merged
rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks:sreq
Aug 19, 2022
Merged

fix: allow 90m session requests. Prompt for cannot meet at time reasoning.#4345
rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks:sreq

Conversation

@rjsparks
Copy link
Copy Markdown
Member

@rjsparks rjsparks commented Aug 18, 2022

No description provided.

@rjsparks rjsparks changed the title fix: allow 90m session requests. Prompt for cannot meet at time reaso… fix: allow 90m session requests. Prompt for cannot meet at time reasoning. Aug 18, 2022
@rjsparks
Copy link
Copy Markdown
Member Author

This is a quick fix for new 115 requirements. In the future, we should make session duration options a configuration point for meetings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2022

Codecov Report

Merging #4345 (6d72620) into main (0f703a6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4345      +/-   ##
==========================================
- Coverage   88.49%   88.48%   -0.01%     
==========================================
  Files         294      294              
  Lines       39271    39270       -1     
==========================================
- Hits        34752    34750       -2     
- Misses       4519     4520       +1     
Impacted Files Coverage Δ
ietf/secr/sreq/forms.py 98.27% <ø> (-0.01%) ⬇️
ietf/meeting/forms.py 97.01% <100.00%> (ø)
ietf/doc/views_search.py 89.67% <0.00%> (-0.44%) ⬇️
ietf/utils/text.py 85.97% <0.00%> (+0.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larseggert
Copy link
Copy Markdown
Collaborator

larseggert commented Aug 19, 2022

So do you think this will be ready Monday? Or should I notify the IESG of potential delays? (Which would be fine, as discussed.)

@rjsparks
Copy link
Copy Markdown
Member Author

Depends on build and test.

@rjsparks rjsparks merged commit 1778652 into ietf-tools:main Aug 19, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 23, 2022
@rjsparks rjsparks deleted the sreq branch October 13, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants