fix: Don't require a responsible AD to be identified for new status change#4297
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Aug 1, 2022
Merged
fix: Don't require a responsible AD to be identified for new status change#4297rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
rjsparks
requested changes
Jul 29, 2022
| title = forms.CharField(max_length=255, label="Title", required=True) | ||
| ad = forms.ModelChoiceField(Person.objects.filter(role__name="ad", role__group__state="active",role__group__type='area').order_by('name'), | ||
| label="Shepherding AD", empty_label="(None)", required=True) | ||
| label="Shepherding AD", empty_label="(None)", required=False) |
Member
There was a problem hiding this comment.
This has to come with a migration. (The tests should really complain if migrations are missing).
Member
There was a problem hiding this comment.
Nevermind - reading too fast and was thinking models rather than forms.
rjsparks
approved these changes
Aug 1, 2022
Member
|
Shouldn't have approved this - the tests still required that the forms fail if you don't supply an AD. Will provide a fix, but yet another place where we are letting failing tests slide and real issues slide through with them. |
rjsparks
added a commit
to rjsparks/datatracker
that referenced
this pull request
Aug 2, 2022
rjsparks
added a commit
that referenced
this pull request
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4159