Skip to content

fix: add missing slides + minutes tabs to session materials dialog #4274 - #4275

Merged
rjsparks merged 4 commits into
ietf-tools:mainfrom
NGPixel:fix-4274
Jul 26, 2022
Merged

fix: add missing slides + minutes tabs to session materials dialog #4274#4275
rjsparks merged 4 commits into
ietf-tools:mainfrom
NGPixel:fix-4274

Conversation

@NGPixel

@NGPixel NGPixel commented Jul 26, 2022

Copy link
Copy Markdown
Member

Adds the missing Slides and Minutes tabs to the session materials dialog on the agenda-neue page.

image

Fixes #4274

@NGPixel
NGPixel requested a review from rjsparks July 26, 2022 00:42
@NGPixel
NGPixel marked this pull request as ready for review July 26, 2022 00:49
@codecov

codecov Bot commented Jul 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4275 (74286e8) into main (fe1f51a) will increase coverage by 0.00%.
The diff coverage is 89.65%.

@@           Coverage Diff           @@
##             main    #4275   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         294      294           
  Lines       39197    39205    +8     
=======================================
+ Hits        34652    34661    +9     
+ Misses       4545     4544    -1     
Impacted Files Coverage Δ
ietf/api/urls.py 100.00% <ø> (ø)
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/nomcom/forms.py 95.39% <ø> (ø)
ietf/nomcom/models.py 91.73% <ø> (ø)
ietf/utils/markdown.py 100.00% <ø> (ø)
ietf/meeting/views.py 90.78% <73.68%> (-0.04%) ⬇️
ietf/doc/views_draft.py 91.90% <94.11%> (-0.09%) ⬇️
ietf/doc/views_ballot.py 91.86% <100.00%> (+0.10%) ⬆️
ietf/doc/views_doc.py 90.53% <100.00%> (+0.04%) ⬆️
ietf/doc/views_status_change.py 93.36% <100.00%> (+0.20%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236c3f5...74286e8. Read the comment docs.

@rjsparks
rjsparks merged commit aea533e into ietf-tools:main Jul 26, 2022
@NGPixel
NGPixel deleted the fix-4274 branch July 26, 2022 19:15
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agenda-neue - Show agenda materials doesn't show slides

2 participants