fix: Update timezone on the interim create page#4262
Merged
rjsparks merged 2 commits intoJul 26, 2022
Merged
Conversation
The interim creation screen will set the timezone to the timezone of the browser. Unfortunately, the UI element was never refreshed, so it remained on its loaded default, thus telling the user the wrong value. This change adds a timezone widget refresh to the end of the function that loads the browser's local timezone into the timezone value. This change also adds code to update the 'Local timezone' help text for the start time and end time input bozes to call out the selected timezone specifically. Fixes ietf-tools#3898
Codecov Report
@@ Coverage Diff @@
## main #4262 +/- ##
=======================================
Coverage 88.40% 88.41%
=======================================
Files 294 294
Lines 39197 39199 +2
=======================================
+ Hits 34652 34656 +4
+ Misses 4545 4543 -2
Continue to review full report at Codecov.
|
jennifer-richards
requested changes
Jul 24, 2022
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
Looks good, just some minor lint.
It strikes me as a little awkward that we now have to hook up the change event on the timezone input before we call initTimeZone(). It might be worth adding a comment to discourage someone from "helpfully" switching that around.
NGPixel
changed the title
NGPixel
approved these changes
Jul 26, 2022
jennifer-richards
approved these changes
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interim creation screen will set the timezone to the timezone of
the browser. Unfortunately, the UI element was never refreshed, so
it remained on its loaded default, thus telling the user the wrong
value.
This change adds a timezone widget refresh to the end of the function that
loads the browser's local timezone into the timezone value.
This change also adds code to update the 'Local timezone' help text
for the start time and end time input bozes to
call out the selected timezone specifically.
(Finally, it adds a newline at the end of the file, since none was present previously)
Fixes #3898