Fix: corrects the IESG evaluation record summary for approved docs#4261
Conversation
…nts where the IESG state is approved (announced or not).
This is a correction to a previous fix that didn't pass all the tests for some documents
Corrects the previous fix by removing commented out code. Sigh. At least these are free.
Codecov Report
@@ Coverage Diff @@
## main #4261 +/- ##
==========================================
+ Coverage 88.40% 88.41% +0.01%
==========================================
Files 294 294
Lines 39197 39200 +3
==========================================
+ Hits 34652 34659 +7
+ Misses 4545 4541 -4
Continue to review full report at Codecov.
|
| else: | ||
| position_groups.append(g) | ||
|
|
||
| iesg = doc.get_state("draft-iesg") |
There was a problem hiding this comment.
There is a get_state_slug function that would have done the same as these two lines
| {% endif %} | ||
| {% endif %} | ||
| {% if not ballot_open %} | ||
| {% if not ballot_open or iesg_state == "ann" or iesg_state == "approved" %} |
There was a problem hiding this comment.
I'm a little uncomfortable that this now doesn't tell the truth - While in 'approved", the ballot is, in reality, still open as far as the datatracker is concerned, but the IESG will not make more changes to positions.It is in the transient phase waiting for the secretariat to clear, hence close, it at the time of announcement.
But the subtlety isn't really useful to the consumer of this message, so we'll go with this as is.
2 participants
Fixes #3962.
This is done by extracting the IESG state (if applicable) and checking the state for approved (announced or not announced) documents. Documents in this state are made to works like documents in the "rfcqueue" or "pub" states, i.e., they list the status of the last ballot.