feat: Add list page as requested in #4242 - #4259
Conversation
and their current workload. Include links to the specific dashboards for each area director. This new page is in doc/ad/.
and their current workload. Include links to the specific dashboards for each area director. This new page is in doc/ad/.
|
|
||
| return cached_redirect(cache_key, urlreverse('ietf.doc.views_search.search') + search_args) | ||
|
|
||
| def ad_dashboard_group_type(doc): |
There was a problem hiding this comment.
This adds a new point of maintenance when new document types are created. Instead of literal strings, why isn't this using DocTypeName.name? (see
datatracker/ietf/doc/views_doc.py
Line 560 in 1ba8789
| if doc.type.slug=='draft': | ||
| if doc.get_state_slug('draft') == 'rfc': | ||
| return 'RFC' | ||
| elif doc.get_state_slug('draft') == 'active' and doc.get_state_slug('draft-iesg') and doc.get_state('draft-iesg').name in ('RFC Ed Queue Internet-Draft'): |
There was a problem hiding this comment.
Should that be ...in ('RFC Ed Queue', 'Internet-Draft')
There was a problem hiding this comment.
This looks like a real bug. Please address it, and consider the other feedback.
| return True | ||
|
|
||
| @register.filter | ||
| def get_hash(h, key): |
There was a problem hiding this comment.
Suggest naming this get_from_dict or something that better matches the dict Python data type. (There's a similar filter lookup in agenda_custom_tags.py that could perhaps be moved and reused - this is a better place for it.)
| return None | ||
| else: | ||
| return 'I-D' | ||
| elif doc.type.slug=='conflrev': |
There was a problem hiding this comment.
Similar to @rjsparks's comment above would be better to make use of the DocTypeName data rather than repeating it here. A single doc.type.slug in [] test could replace a bunch of these cases
rjsparks
left a comment
rjsparks
left a comment
There was a problem hiding this comment.
(See previous comments for requested change)
|
Jennifer Richards writes:
+ elif doc.get_state_slug('draft') == 'active' and doc.get_state_slug('draft-iesg') and doc.get_state('draft-iesg').name in ('RFC Ed Queue Internet-Draft'):
Should that be ...in ('RFC Ed Queue', 'Internet-Draft')
Actually it should be 'RFC Ed Queue' without the Internet-Draft. It
worked as 'RFC Ed Queue Internet-Draft' did include RFC Ed Queue that
is in the draft-iesg name.
The ad_dashboard_group do return "RFC Ed Queue Internet-Draft", which
was why I had cut & pasted it here.
--
***@***.***
|
|
There are other comments to consider, but I wanted to point out: |
NGPixel
changed the title
|
Rather than push into Tero's branch, I'm working in https://github.com/rjsparks/datatracker/tree/ad-list-page. I'll eventually make a PR that supersedes this one. |
|
Replaced by #4315. |
3 participants
Add new page to list all area directors and their current workload. Include links to the specific dashboards
for each area director. This new page is in doc/ad/.