Skip to content

Fix4209#4256

Closed
russhousley wants to merge 3 commits into
ietf-tools:mainfrom
russhousley:fix4209
Closed

Fix4209#4256
russhousley wants to merge 3 commits into
ietf-tools:mainfrom
russhousley:fix4209

Conversation

@russhousley

Copy link
Copy Markdown
Collaborator

Fix: Provide a button to Submit to IESG on the Change IETF WG state when that is the recommended next state.
Fixes #4209.

@codecov

codecov Bot commented Jul 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4256 (205b544) into main (fe1f51a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4256   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         294      294           
  Lines       39197    39204    +7     
=======================================
+ Hits        34652    34660    +8     
+ Misses       4545     4544    -1     
Impacted Files Coverage Δ
ietf/doc/views_draft.py 91.84% <100.00%> (-0.15%) ⬇️
ietf/nomcom/utils.py 91.64% <0.00%> (-0.27%) ⬇️
ietf/utils/markdown.py 100.00% <0.00%> (ø)
ietf/doc/views_doc.py 90.52% <0.00%> (+0.02%) ⬆️
ietf/doc/views_ballot.py 91.86% <0.00%> (+0.10%) ⬆️
ietf/doc/views_status_change.py 93.36% <0.00%> (+0.20%) ⬆️
ietf/utils/text.py 87.19% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce050fc...205b544. Read the comment docs.

@larseggert

Copy link
Copy Markdown
Collaborator

I guess we both worked on this: #4254

@russhousley

Copy link
Copy Markdown
Collaborator Author

I like what you did for the template better than my approach. However, I think that the change in the view to remove sub-pub from the pull down is also needed.

@larseggert

Copy link
Copy Markdown
Collaborator

Do you want to combine the two into your PR?

@russhousley

Copy link
Copy Markdown
Collaborator Author

Yours is easier. You just need to add one line to /ietf/doc/views_draft.py.

I just need to take line 1567 from https://github.com/russhousley/datatracker/blob/fix4209/ietf/doc/views_draft.py

The other changes in my PR can be ignored because you made a more robust fix in the template.

larseggert added a commit to larseggert/datatracker that referenced this pull request Jul 24, 2022
@larseggert

Copy link
Copy Markdown
Collaborator

Done! Please check?

@rjsparks

Copy link
Copy Markdown
Member

Closing this as OBE by #4254

@rjsparks rjsparks closed this Jul 24, 2022
rjsparks pushed a commit that referenced this pull request Jul 24, 2022
…-) (#4254)

* fix: Make the "submit to IESG" workflow less surprising to @LPardue :-)

Fixes #4209

* Merge part of #4256
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 28, 2022
@russhousley russhousley deleted the fix4209 branch October 26, 2022 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WG draft "Submit to IESG for publication" workflow is infuriating

3 participants