Skip to content

feat(nomcom): Allow nomcom chair to turn volunteer acceptance on and off - #4251

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
jimfenton:nomcom-vol
Jul 24, 2022
Merged

feat(nomcom): Allow nomcom chair to turn volunteer acceptance on and off#4251
rjsparks merged 2 commits into
ietf-tools:mainfrom
jimfenton:nomcom-vol

Conversation

@jimfenton

Copy link
Copy Markdown
Collaborator

Fixes #4105
Also allows chair to set date of first call for volunteers. If this should be read-only and set by the code, let me know.

Fixes #4105
Also allows chair to set date of first call for volunteers. If this should be read-only and set by the code, let me know.
@codecov

codecov Bot commented Jul 23, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4251 (94b5fce) into main (fe1f51a) will increase coverage by 0.00%.
The diff coverage is 96.15%.

@@           Coverage Diff           @@
##             main    #4251   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         294      294           
  Lines       39197    39198    +1     
=======================================
+ Hits        34652    34655    +3     
+ Misses       4545     4543    -2     
Impacted Files Coverage Δ
ietf/doc/urls.py 100.00% <ø> (ø)
ietf/nomcom/forms.py 95.39% <ø> (ø)
ietf/nomcom/models.py 91.73% <ø> (ø)
ietf/utils/markdown.py 100.00% <ø> (ø)
ietf/doc/views_draft.py 91.98% <93.75%> (ø)
ietf/doc/views_doc.py 90.52% <100.00%> (+0.02%) ⬆️
ietf/utils/text.py 85.97% <100.00%> (+0.26%) ⬆️
ietf/doc/views_ballot.py 91.86% <0.00%> (+0.10%) ⬆️
ietf/doc/views_status_change.py 93.36% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba8789...94b5fce. Read the comment docs.

@rjsparks
rjsparks merged commit 3aab73d into ietf-tools:main Jul 24, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The nomcom settings page does not let the chair set the "accepting volunteers" option

2 participants