Skip to content

fix: do not set user template var in ietfauth views - #4216

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
painless-security:jennifer/template-user
Jul 15, 2022
Merged

fix: do not set user template var in ietfauth views#4216
rjsparks merged 1 commit into
ietf-tools:mainfrom
painless-security:jennifer/template-user

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

This prevents the reset password view from falsely indicating that the user is logged in, which fixes #3568. For the password reset, indicate the user who will be affected. In other cases, user was unnecessarily being set to request.user - this is done automatically.

Lets the `user` variable pick up `request.user`.
Fixes ietf-tools#3568
@rjsparks
rjsparks merged commit 067ae17 into ietf-tools:main Jul 15, 2022
@jennifer-richards
jennifer-richards deleted the jennifer/template-user branch July 15, 2022 20:01
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

password reset views conflate user and request.user

2 participants