fix: Make the IPR search form work when enter is pressed#4114
Merged
Conversation
jennifer-richards
approved these changes
Jun 22, 2022
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
Looks good to me. One question about the state input hack, but the answer may be "no" and it's not worth holding up over.
| $("#id_state") | ||
| .addClass("list-inline"); | ||
| $("#id_state .form-check") | ||
| .addClass("form-check-inline"); |
Member
There was a problem hiding this comment.
Can this not be done in the template?
Collaborator
Author
There was a problem hiding this comment.
These forms would need some serious work to better work with bs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.