chore: Use URL resolver in more places - #4104
Merged
Merged
Conversation
larseggert
marked this pull request as ready for review
June 21, 2022 14:51
rjsparks
requested changes
Jun 21, 2022
| <a href="{% url 'ietf.group.views.active_groups' group_type='wg' %}">The IETF Area Director(s)</a> | ||
| <br> | ||
| <a href="/wg/">The IETF Working Group Discussion List</a> | ||
| <a href="{% url 'ietf.group.views.active_groups' group_type='wg' %}">The IETF Working Group Discussion List</a> |
Member
There was a problem hiding this comment.
fyi - no change here requested:
These changes are find, but this template and guide_to_ietf.html as a whole are suspect. We should find an IAB person to review/update them.
Member
|
This is massive, and definitely better than what it's changing. I've asked for more than you've done, but if you don't have time, we could accept this and queue the suggestions for "even better" for later. |
larseggert
force-pushed
the
use-url-resolver
branch
from
June 22, 2022 06:34
82c934c to
372f92b
Compare
rjsparks
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As well as
settings.IDTRACKER_BASE_URLinstead of hard-coding the value.