Skip to content

feat(ui): new dynamic agenda view#4086

Merged
rjsparks merged 72 commits into
mainfrom
feat/agenda-neue
Jul 13, 2022
Merged

feat(ui): new dynamic agenda view#4086
rjsparks merged 72 commits into
mainfrom
feat/agenda-neue

Conversation

@NGPixel

@NGPixel NGPixel commented Jun 15, 2022

Copy link
Copy Markdown
Member

Reworking of the agenda + floor plan page into a fully dynamic Vue.js page.

Goals

  • Modernize the UI / Improve ease of use
  • Reduce page load time by making the filtering and other heavy operations by the client
  • Use a modern client framework (Vue 3)
  • Use Vite (instead of Parcel) for views using Vue 3 + Django-Vite integration

Instructions

To try in dev mode, you need to run yarn dev in a separate process, then start the server as usual. Unlike Parcel (where assets are written to disk and then read by Django), assets are generated on the fly and are proxied by Django to the Vite process listening on port 3000.

Remaining work / Known bugs

  • Offload data loading to separate API endpoint
  • Update URL to match current selection
  • Write tests

@NGPixel NGPixel marked this pull request as ready for review June 29, 2022 21:51
@NGPixel NGPixel requested a review from rjsparks June 29, 2022 21:51
@NGPixel NGPixel marked this pull request as draft July 7, 2022 17:34
@NGPixel NGPixel marked this pull request as ready for review July 12, 2022 21:08
@codecov

codecov Bot commented Jul 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4086 (ede3248) into main (b41841a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4086      +/-   ##
==========================================
- Coverage   88.21%   88.19%   -0.02%     
==========================================
  Files         295      295              
  Lines       39223    39264      +41     
==========================================
+ Hits        34600    34630      +30     
- Misses       4623     4634      +11     
Impacted Files Coverage Δ
ietf/utils/pipe.py 82.60% <0.00%> (-4.35%) ⬇️
ietf/meeting/views.py 90.81% <0.00%> (-0.34%) ⬇️
ietf/meeting/urls.py 100.00% <0.00%> (ø)
ietf/submit/forms.py 82.88% <0.00%> (ø)
ietf/meeting/models.py 86.84% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57818a0...ede3248. Read the comment docs.

@NGPixel NGPixel force-pushed the feat/agenda-neue branch from 107f3bf to ede3248 Compare July 13, 2022 21:06
@rjsparks rjsparks merged commit aa9490f into main Jul 13, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants