Skip to content

feat: Use bs5 for htmlized doc - #4082

Merged
NGPixel merged 56 commits into
ietf-tools:htmlizefrom
larseggert:fix-htmlization
Sep 13, 2022
Merged

feat: Use bs5 for htmlized doc#4082
NGPixel merged 56 commits into
ietf-tools:htmlizefrom
larseggert:fix-htmlization

Conversation

@larseggert

@larseggert larseggert commented Jun 14, 2022

Copy link
Copy Markdown
Collaborator

This gets rid of a bunch of old code by re-using document_main to render htmlized docs into a new set of bs5-based templates.

Also fixes #4057 and #3653.

This depends on ietf-tools/rfc2html#11 and ietf-tools/rfc2html#12.

@larseggert
larseggert force-pushed the fix-htmlization branch 2 times, most recently from d573215 to c73d246 Compare June 15, 2022 07:47
@larseggert
larseggert marked this pull request as ready for review June 15, 2022 10:03
@rjsparks

Copy link
Copy Markdown
Member

This is a pretty big change of what's really the most heavily fetched format from the datatracker. We may want to phase this in? (and possible fix the html brokenness in rfc2html at the same time).

As mentioned out of band, when I first moved this to the datatracker, I didn't preserve the colored header and got immediate feedback that people wanted it back.

Please look at #3466.

@larseggert

Copy link
Copy Markdown
Collaborator Author

I'm adding the colored header - as a colored badge.

@larseggert
larseggert requested a review from rjsparks June 20, 2022 09:43
@larseggert

Copy link
Copy Markdown
Collaborator Author

We may want to phase this in?

We should definitely deploy on sandbox first and ask for feedback.

@larseggert
larseggert force-pushed the fix-htmlization branch 2 times, most recently from bcd66b6 to ec835c0 Compare July 9, 2022 08:34
@larseggert

Copy link
Copy Markdown
Collaborator Author

@rjsparks should we chat about how to make this available for community feedback?

@rjsparks

Copy link
Copy Markdown
Member

We can do a deployment of the branch on the sandbox server using a new DNS name (such as htmlize-preview.ietf.org), or you could look at rewiring the PR to put this htmlization at a different endpoint than the current, so that they are both available in production for some time (/doc/htmlpreview/ perhaps). If we go with deploying the branch, it would be good to keep it close to main.

@larseggert

larseggert commented Jul 22, 2022

Copy link
Copy Markdown
Collaborator Author

I'll look I to adding another button for deployment testing via main.

Actually, it will require a lot of work to rework the PR for that. I think deploying the branch is easier. We can also first get some initial feedback during the codesprint.

@larseggert

larseggert commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator Author

@rjsparks I think this is ready for you to take a look (htmlization and pdfization of various documents). If you think it's ready, maybe we do public testing?

Comment thread ietf/static/css/document_html_txt.scss Outdated
Comment thread ietf/static/css/document_html_txt.scss
@NGPixel
NGPixel changed the base branch from main to htmlize September 13, 2022 19:14
@NGPixel
NGPixel merged commit 8049d9e into ietf-tools:htmlize Sep 13, 2022
@rjsparks

Copy link
Copy Markdown
Member

Moving this into a branch at ietf-tools to assist with a feedback deployment

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Unexpected type size behavior in htmlized drafts

4 participants