feat: Replace graphviz with d3 - #4067
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4067 +/- ##
==========================================
+ Coverage 88.20% 88.39% +0.19%
==========================================
Files 295 294 -1
Lines 39279 39197 -82
==========================================
+ Hits 34645 34649 +4
+ Misses 4634 4548 -86
Continue to review full report at Codecov.
|
|
Need to figure out why @rjsparks sees different data in the graphs, and why Chrome doesn't like my SVG. |
f81c531 to
c53062a
Compare
|
@rjsparks maybe gives this another look? Made a bunch of changes. |
|
The legend doesn't explain the colors of the arrows (which dependencies are normative, etc.) |
|
Yes, only on hover. Labels arcs are though. |
|
I'm not getting any hover effects on the graph or the legend, even after a complete rebuild. I'll ask Nick to look. |
|
just to be clear, I get this for quic, and hoving over anything has no effect: |
|
I'm not getting any hover effects on the bubbles either. |
| url(r'^history/addcomment/$',views.add_comment), | ||
| url(r'^email/$', views.email), | ||
| url(r'^deps/(?P<output_type>[\w-]+)/$', views.dependencies), | ||
| url(r'^deps.json$', views.dependencies), |
There was a problem hiding this comment.
I'll push a fix for this, but watch out for this trap in the future. That bare . is in a regex. You really wanted \.
|
This doesn't look right, but I think we're close enough to bring it in, and can address this (and some protonopia issues I have with the colors) later. |
3 participants
This eliminates the datatracker's dependency on graphviz, by using d3 to draw the document dependency graph.