Skip to content

fix: Update document shepherd writeup template based on community review#4042

Merged
rjsparks merged 25 commits into
ietf-tools:mainfrom
larseggert:update-shepherd-writeup
Jul 7, 2022
Merged

fix: Update document shepherd writeup template based on community review#4042
rjsparks merged 25 commits into
ietf-tools:mainfrom
larseggert:update-shepherd-writeup

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

Leaving this as a draft PR for now, so that further community feedback can be accumulated.

@LPardue LPardue left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed these changes with my community member hat on, and find them to all be helpful.

Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
@richsalz

richsalz commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

It would be easier to review this is the content changes were in a separate PR from the markup/formatting changes.

@larseggert

Copy link
Copy Markdown
Collaborator Author

@cabo, does the revised question 5 work for you?

@cabo

cabo commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

@larseggert : Yes, that works for me.

Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
@larseggert
larseggert force-pushed the update-shepherd-writeup branch from 1e86a1c to f073981 Compare June 3, 2022 06:39
@mnot

mnot commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

One more question that seems to have fallen through the cracks: Question 7 is odd, in that it's not horizontal across all specs; it's limited to just YANG documents.

To me, the logical thing to do is to fold it into question 6 or 10 (with less detail).

Alternatively, if we're going to have vertical shepherd criteria like this, it would be good to understand how to get onto the list; e.g., there are some HTTP-specific questions I'd like to ask.

Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
@larseggert

Copy link
Copy Markdown
Collaborator Author

Question 7 is odd, in that it's not horizontal across all specs; it's limited to just YANG documents.

YANG is special :-)

Seriously though, it does require quite a bit of extra checks.

@cabo

cabo commented Jun 9, 2022

Copy link
Copy Markdown
Collaborator

YANG is special :-)

Seriously though, it does require quite a bit of extra checks.

What makes YANG special is that it is the only FDT (format description technique) that we have embraced at a level that requires tool support throughout the process.

Expect this list to grow as we find other FDTs that we want to take to this level.
We can adapt this template once that is the case.

@mnot

mnot commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

OK, so I'd propose a new item then (probably right after 7):

If your document uses HTTP, list any divergences from the guidelines in BCP56[1]. Does your document follow the editorial guidelines for HTTP specifications[2], and if not, why? Do your HTTP message examples validate?[3]

  1. RFC9205
  2. https://httpwg.org/admin/editors/style-guide
  3. https://github.com/mnot/rfc-http-validate

@cabo

cabo commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

OK, so I'd propose a new item then (probably right after 7):

This looks a lot like we should have a separate document with pointers how to check for the guidelines of specific verticals. That document could move faster than the shepherd template, which would reference it.
(It could also be more specific about what is expected for the YANG vertical.)

@mnot

mnot commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

That would work for me.

@larseggert

larseggert commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator Author

I want to push back here. The purpose of the document writeup is to inform the responsible AD and the rest of the IESG. If we feel that we need to ask a specific question about YANG, we should be free to do so. On the flip side, if we don't feel like we need to for HTTP, that is fine, too (and not necessarily a bad sign.)

@cabo

cabo commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator

Whatever you decide the shepherd needs to report about, I want that other document!

@mnot

mnot commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@larseggert that kind of sends a message that the IESG is more interested in YANG than other parts of the community. Do you really want to go down that road?

@larseggert

larseggert commented Jun 10, 2022

Copy link
Copy Markdown
Collaborator Author

The document shepherd writeup is not about IESG interest. This is about gathering the required information to ease the review process for a set of very busy people.

Comment thread ietf/templates/doc/shepherd_writeup.txt Outdated
@mnot

mnot commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

@larseggert I'd like an answer from the IESG on my proposal above. Thanks.

@larseggert

Copy link
Copy Markdown
Collaborator Author

@larseggert I'd like an answer from the IESG on my proposal above. Thanks.

Please email them? I am about to head out on vacation. Thanks!

@evyncke

evyncke commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

LGTM

@mirjak mirjak left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@larseggert
larseggert marked this pull request as ready for review July 4, 2022 14:07
@codecov

codecov Bot commented Jul 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4042 (526049c) into main (7de5d93) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
- Coverage   88.21%   88.21%   -0.01%     
==========================================
  Files         295      295              
  Lines       39164    39169       +5     
==========================================
+ Hits        34548    34552       +4     
- Misses       4616     4617       +1     
Impacted Files Coverage Δ
ietf/meeting/views.py 91.15% <100.00%> (+0.01%) ⬆️
ietf/group/utils.py 93.69% <0.00%> (-0.91%) ⬇️
ietf/utils/pipe.py 86.95% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba5099...526049c. Read the comment docs.

{# Keep in sync with https://github.com/ietf-chairs/chairs.ietf.org/blob/main/documents/qa-style-writeup-template.md #}{% if doc.stream %}{% if doc.stream.slug == 'ietf' %}# Document Shepherd Write-Up

*This version is dated 8 April 2022.*
*This version is dated 1 June 2022.*

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm whether this should be updated to sometime around 4 Jul?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

@rjsparks
rjsparks merged commit 21452b7 into ietf-tools:main Jul 7, 2022
@larseggert
larseggert deleted the update-shepherd-writeup branch July 7, 2022 17:29
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants