Skip to content

fix: Fix include of bootstrap-icons #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Jun 1, 2022
Merged

fix: Fix include of bootstrap-icons #4039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ietf/static/css/ietf.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ $popover-max-width: 100%;
// Utilities
@import "bootstrap/scss/utilities/api";

// Make the bootstrap icons available.
$bootstrap-icons-font-src: url("npm:bootstrap-icons/font/fonts/bootstrap-icons.woff2") format("woff2"),
url("npm:bootstrap-icons/font/fonts/bootstrap-icons.woff") format("woff");
@import "bootstrap-icons/font/bootstrap-icons";

// Leave room for fixed-top navbar...
body {
padding-top: 60px;
Expand Down
3 changes: 0 additions & 3 deletions ietf/static/js/ietf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ import "bootstrap/js/dist/tooltip";

import jquery from "jquery";

// Make the bootstrap icons available. Yes, we require CSS in JS, parcel wants this.
require("bootstrap-icons/font/bootstrap-icons.css");

window.$ = window.jQuery = jquery;
if (!process.env.BUILD_DEPLOY) {
// get warnings for using deprecated jquery features
Expand Down