Skip to content

fix: Don't show To Subscribe on group about when url is empty. Fixes #4022. - #4023

Merged
rjsparks merged 1 commit into
ietf-tools:mainfrom
rjsparks:nosubscribeto
May 25, 2022
Merged

fix: Don't show To Subscribe on group about when url is empty. Fixes #4022.#4023
rjsparks merged 1 commit into
ietf-tools:mainfrom
rjsparks:nosubscribeto

Conversation

@rjsparks

@rjsparks rjsparks commented May 25, 2022

Copy link
Copy Markdown
Member

No description provided.

@rjsparks rjsparks changed the title fix: Don't show To Subscribe on group about when there's no url to su… fix: Don't show To Subscribe on group about when url is empty May 25, 2022
@rjsparks rjsparks changed the title fix: Don't show To Subscribe on group about when url is empty fix: Don't show To Subscribe on group about when url is empty. Fixes #4022. May 25, 2022
@codecov

codecov Bot commented May 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4023 (00c10e6) into main (c89f7c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4023   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         297      297           
  Lines       39278    39275    -3     
=======================================
- Hits        34620    34619    -1     
+ Misses       4658     4656    -2     
Impacted Files Coverage Δ
ietf/sync/iana.py 89.28% <100.00%> (+0.98%) ⬆️
ietf/submit/forms.py 82.92% <0.00%> (-0.23%) ⬇️
ietf/utils/pipe.py 86.95% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6094645...00c10e6. Read the comment docs.

@rjsparks
rjsparks merged commit 2f4b493 into ietf-tools:main May 25, 2022
@rjsparks
rjsparks deleted the nosubscribeto branch May 25, 2022 19:52
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants