chore: make /assets a named volume for dev container#4018
Merged
Conversation
1 task
larseggert
reviewed
May 25, 2022
larseggert
left a comment
larseggert
left a comment
Collaborator
There was a problem hiding this comment.
Can we remove the data directory entirely?
Also, check where else data/developers is used, I think at least docker/scripts/app-create-dirs.sh also needs to change.
Member
|
/data is used by other things than the synced artifacts (it's where coverage keeps some bits I think, and where we provide nomcom public keys. Agree that app-create-dirs.sh needs to be touched. |
Member
Author
|
|
rjsparks
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a named volume "app-assets" mapped to
/assetsinside the dev container.Configs and scripts were modified to point to this new location.
fixes #4012