Skip to content

chore(dev): fix chromedriver crash during tests in devcontainer - #3978

Closed
NGPixel wants to merge 4 commits into
ietf-tools:mainfrom
NGPixel:fix-chromedriver-crash
Closed

chore(dev): fix chromedriver crash during tests in devcontainer#3978
NGPixel wants to merge 4 commits into
ietf-tools:mainfrom
NGPixel:fix-chromedriver-crash

Conversation

@NGPixel

@NGPixel NGPixel commented May 16, 2022

Copy link
Copy Markdown
Member

Fixes chromedriver crashing during tests by setting 1777 permissions to /dev/shm

@NGPixel
NGPixel requested a review from rjsparks May 16, 2022 20:56
@NGPixel NGPixel changed the title chore: fix chromedriver crash during tests chore: fix chromedriver crash during tests in devcontainer May 17, 2022
@NGPixel NGPixel changed the title chore: fix chromedriver crash during tests in devcontainer chore(dev): fix chromedriver crash during tests in devcontainer May 17, 2022
Comment thread .devcontainer/devcontainer.json Outdated
Comment thread .vscode/extensions.json
"arcanis.vscode-zipfs",
"dbaeumer.vscode-eslint"
]
"recommendations": []

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems unrelated to this particular problem?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrelated but it's to silence some popups when opening vscode. I can make a separate PR if you prefer, but it's quite a tiny change with no impact.

@NGPixel
NGPixel requested a review from rjsparks May 18, 2022 19:07
@NGPixel

NGPixel commented May 19, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of #3981.

@NGPixel NGPixel closed this May 19, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@NGPixel
NGPixel deleted the fix-chromedriver-crash branch June 16, 2022 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants