chore(dev): fix chromedriver crash during tests in devcontainer - #3978
Closed
NGPixel wants to merge 4 commits into
Closed
chore(dev): fix chromedriver crash during tests in devcontainer#3978NGPixel wants to merge 4 commits into
NGPixel wants to merge 4 commits into
Conversation
rjsparks
requested changes
May 18, 2022
| "arcanis.vscode-zipfs", | ||
| "dbaeumer.vscode-eslint" | ||
| ] | ||
| "recommendations": [] |
Member
There was a problem hiding this comment.
This also seems unrelated to this particular problem?
Member
Author
There was a problem hiding this comment.
It's unrelated but it's to silence some popups when opening vscode. I can make a separate PR if you prefer, but it's quite a tiny change with no impact.
Member
Author
|
Closing in favor of #3981. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes chromedriver crashing during tests by setting
1777permissions to/dev/shm