test: fix more validation issues - #3975
Merged
Merged
Conversation
Collaborator
Author
|
Not sure why the tests fail, they succeed locally |
NGPixel
changed the title
rjsparks
approved these changes
May 18, 2022
| nomcom.url = None | ||
| if year >= 2002: | ||
| nomcom.ann_url = "/nomcom/ann/#%4d" % year | ||
| nomcom.ann_url = "/nomcom/ann/#nomcom-%4d" % year |
Member
There was a problem hiding this comment.
We'll go with this for now, but consider dropping the hyphen since nomcom2021 is a group.
rjsparks
reviewed
May 18, 2022
| .baseform textarea { | ||
| width: 80%; | ||
| } | ||
| /* TODO: this should use bs5 styling and ideally be integrated into the code */ |
Member
There was a problem hiding this comment.
What tooling are you using that shows the removed styling was not used?
Collaborator
Author
There was a problem hiding this comment.
I grepped for "baseform" in the repo :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including the ones @rjsparks sent me in email