feat: begin supporting the new rfc editor model#3960
Merged
rjsparks merged 7 commits intoietf-tools:mainfrom May 20, 2022
Merged
feat: begin supporting the new rfc editor model#3960rjsparks merged 7 commits intoietf-tools:mainfrom
rjsparks merged 7 commits intoietf-tools:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3960 +/- ##
==========================================
- Coverage 88.14% 88.14% -0.01%
==========================================
Files 297 297
Lines 39273 39278 +5
==========================================
+ Hits 34618 34620 +2
- Misses 4655 4658 +3
Continue to review full report at Codecov.
|
larseggert
approved these changes
May 15, 2022
Collaborator
larseggert
left a comment
larseggert
left a comment
There was a problem hiding this comment.
Noe an expert here, but LGTM.
rjsparks
changed the title
jennifer-richards
approved these changes
May 20, 2022
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks good to me. Only nit is some copyright notices that haven't been updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has one thing that I don't like, but changing it will be a bigger lift. It exposes what had to date been an internal artifact: the group type name slug of
rfcedtypwhich now shows in the urls when following some of the menus.