refactor: tweak the horrible code in SearchableField #3957
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom May 19, 2022
Merged
refactor: tweak the horrible code in SearchableField #3957rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
…e works Fixes ietf-tools#3940. Hopefully doesn't break anything.
Codecov Report
@@ Coverage Diff @@
## main #3957 +/- ##
=======================================
Coverage 88.14% 88.14%
=======================================
Files 297 297
Lines 39273 39273
=======================================
+ Hits 34618 34619 +1
+ Misses 4655 4654 -1
Continue to review full report at Codecov.
|
rjsparks
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So another corner case works.
Fixes #3940. Hopefully doesn't break anything.