ci: add db migrations checks to tests and build workflows - #3920
Merged
Conversation
rjsparks
requested changes
May 2, 2022
| echo "Running checks..." | ||
| ./ietf/manage.py check | ||
| echo "Validating migrations..." | ||
| $do ./ietf/manage.py makemigrations | tee /dev/stderr | $do grep -q "^No changes detected$" || die "Model changes without migrations found." |
Member
There was a problem hiding this comment.
$do (in several places here) no longer makes sense?
Member
There was a problem hiding this comment.
die is also locally defined in the source script.
Member
Author
There was a problem hiding this comment.
ok, I was wondering what $do was used for. I assumed it was some special magic bash keyword...
I'll rework the code.
rjsparks
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3919