fix: use ModelMultipleChoiceField for 'bethere' when hidden#3894
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Apr 26, 2022
Merged
fix: use ModelMultipleChoiceField for 'bethere' when hidden#3894rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
The select2-based fields do not behave well on the SubmissionForm when hidden=True. The ModelMultipleChoiceField is enough for this case.
Codecov Report
@@ Coverage Diff @@
## main #3894 +/- ##
==========================================
- Coverage 88.00% 87.99% -0.01%
==========================================
Files 297 297
Lines 38773 38773
==========================================
- Hits 34122 34119 -3
- Misses 4651 4654 +3
Continue to review full report at Codecov.
|
rjsparks
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3889.