fix: Correctly linkify all current TLDs - #3868
Merged
Merged
Conversation
Member
|
Note that we are on Bleach 4.1.0 until we can move off python3.6 (which is hopefully sometime next week). |
larseggert
marked this pull request as ready for review
April 23, 2022 07:27
Collaborator
Author
|
I misunderstood the bleach API; this should now work (and fix the issue). |
Codecov Report
@@ Coverage Diff @@
## main #3868 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 297 297
Lines 38771 38773 +2
=======================================
+ Hits 34115 34118 +3
+ Misses 4656 4655 -1
Continue to review full report at Codecov.
|
rjsparks
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3866.
Doesn't actually work, because
bleachseems to have deeper issues. See mozilla/bleach#656.