Skip to content

fix: Use unique data-sort attributes#3836

Merged
rjsparks merged 2 commits into
ietf-tools:mainfrom
larseggert:fix-data-sort
Apr 19, 2022
Merged

fix: Use unique data-sort attributes#3836
rjsparks merged 2 commits into
ietf-tools:mainfrom
larseggert:fix-data-sort

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

So list.js properly sorts columns.

So list.js properly sorts columns.
@codecov

codecov Bot commented Apr 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3836 (db691d9) into main (ef4ad54) will increase coverage by 0.03%.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##             main    #3836      +/-   ##
==========================================
+ Coverage   87.95%   87.99%   +0.03%     
==========================================
  Files         296      297       +1     
  Lines       38795    38769      -26     
==========================================
- Hits        34124    34116       -8     
+ Misses       4671     4653      -18     
Impacted Files Coverage Δ
ietf/meeting/models.py 86.08% <ø> (ø)
ietf/meeting/urls.py 100.00% <ø> (ø)
ietf/meeting/utils.py 90.27% <ø> (-0.29%) ⬇️
ietf/name/models.py 100.00% <ø> (ø)
ietf/meeting/views.py 91.02% <96.00%> (+0.42%) ⬆️
ietf/doc/templatetags/ballot_icon.py 84.89% <100.00%> (ø)
ietf/doc/templatetags/ietf_filters.py 81.40% <100.00%> (+0.15%) ⬆️
ietf/doc/views_ballot.py 91.60% <100.00%> (ø)
ietf/doc/views_charter.py 88.72% <100.00%> (ø)
ietf/doc/views_status_change.py 93.04% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44fc55...db691d9. Read the comment docs.

Comment thread ietf/templates/liaisons/liaison_table.html Outdated
Comment thread ietf/templates/nomcom/private_index.html Outdated
Comment thread ietf/templates/nomcom/private_index.html Outdated
@rjsparks rjsparks merged commit f8c06fa into ietf-tools:main Apr 19, 2022
@larseggert larseggert deleted the fix-data-sort branch April 26, 2022 18:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants