fix: offset scrollspy so righthand-nav highlights the correct entry - #3820
Merged
jennifer-richards merged 3 commits intoApr 14, 2022
Merged
Conversation
This seems to be less flaky than the ActionChains implementation. Slight change in behavior - now scrolls the requested element to the middle of the window instead of barely into view.
Codecov Report
@@ Coverage Diff @@
## feat/bs5 #3820 +/- ##
============================================
+ Coverage 87.97% 88.00% +0.02%
============================================
Files 296 297 +1
Lines 38795 38759 -36
============================================
- Hits 34130 34108 -22
+ Misses 4665 4651 -14
Continue to review full report at Codecov.
|
rjsparks
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.