Skip to content

fix: clean up agenda personalization links#3803

Merged
jennifer-richards merged 4 commits into
ietf-tools:feat/bs5from
painless-security:jennifer/personalization-cleanup
Apr 12, 2022
Merged

fix: clean up agenda personalization links#3803
jennifer-richards merged 4 commits into
ietf-tools:feat/bs5from
painless-security:jennifer/personalization-cleanup

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Fixes #3786 and #3787

@codecov

codecov Bot commented Apr 8, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3803 (027d1dc) into feat/bs5 (8bd4851) will increase coverage by 0.00%.
The diff coverage is 98.21%.

❗ Current head 027d1dc differs from pull request most recent head 68bf84a. Consider uploading reports for the commit 68bf84a to get more accurate results

@@            Coverage Diff            @@
##           feat/bs5    #3803   +/-   ##
=========================================
  Coverage     87.97%   87.98%           
=========================================
  Files           296      297    +1     
  Lines         38795    38804    +9     
=========================================
+ Hits          34130    34140   +10     
+ Misses         4665     4664    -1     
Impacted Files Coverage Δ
ietf/meeting/models.py 86.08% <ø> (ø)
ietf/meeting/utils.py 90.27% <ø> (-0.29%) ⬇️
ietf/meeting/views.py 90.73% <95.00%> (+0.02%) ⬆️
ietf/doc/templatetags/ballot_icon.py 84.89% <100.00%> (ø)
ietf/doc/templatetags/ietf_filters.py 81.25% <100.00%> (ø)
ietf/doc/views_ballot.py 91.60% <100.00%> (ø)
ietf/doc/views_charter.py 88.72% <100.00%> (ø)
ietf/doc/views_status_change.py 93.04% <100.00%> (ø)
ietf/ietfauth/views.py 90.57% <100.00%> (ø)
ietf/liaisons/widgets.py 86.11% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3245678...68bf84a. Read the comment docs.

Comment thread ietf/templates/meeting/agenda.html Outdated
{% include "meeting/agenda_filter.html" with filter_categories=filter_categories customize_button_text="Personalize the agenda view..." always_show=personalize %}
{% include "meeting/agenda_personalize_buttonlist.html" with meeting=schedule.meeting only %}
{% include "meeting/agenda_filter.html" with filter_categories=filter_categories customize_button_text="Filter this agenda view..." always_show=personalize %}
{% if personalize %}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - this isn't right - The buttons are supposed to be on the main agenda page as well as the other page, as they are pre-bs5.
After someone customizes with either mechanic, they should be able to easily subscribe or download ics.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I lost track of which buttons these were. It's just the link back to the customized agenda view that needed to be limited. They all needed to be made visible on the personalize tab. Thanks for catching it.

@jennifer-richards

Copy link
Copy Markdown
Member Author

This update restores the webcal / .ics buttons to the agenda tab. It relabels them as "filtered agenda" instead of "personal agenda." It also suppresses the duplicate set of buttons at the very end of the agenda tab. On the personalize tab, these are meant to be useful to someone who has gone through the whole page to select individual sessions, but there's little need for them on the agenda tab.

@jennifer-richards jennifer-richards merged commit c14a303 into ietf-tools:feat/bs5 Apr 12, 2022
@jennifer-richards jennifer-richards deleted the jennifer/personalization-cleanup branch April 12, 2022 15:03
jennifer-richards referenced this pull request in painless-security/datatracker Apr 12, 2022
Fixes test failure caused by ietf-tools#3803.
jennifer-richards referenced this pull request Apr 12, 2022
Fixes test failure caused by ietf-tools#3803.
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants