fix: clean up agenda personalization links#3803
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/bs5 #3803 +/- ##
=========================================
Coverage 87.97% 87.98%
=========================================
Files 296 297 +1
Lines 38795 38804 +9
=========================================
+ Hits 34130 34140 +10
+ Misses 4665 4664 -1
Continue to review full report at Codecov.
|
| {% include "meeting/agenda_filter.html" with filter_categories=filter_categories customize_button_text="Personalize the agenda view..." always_show=personalize %} | ||
| {% include "meeting/agenda_personalize_buttonlist.html" with meeting=schedule.meeting only %} | ||
| {% include "meeting/agenda_filter.html" with filter_categories=filter_categories customize_button_text="Filter this agenda view..." always_show=personalize %} | ||
| {% if personalize %} |
There was a problem hiding this comment.
No - this isn't right - The buttons are supposed to be on the main agenda page as well as the other page, as they are pre-bs5.
After someone customizes with either mechanic, they should be able to easily subscribe or download ics.
There was a problem hiding this comment.
Yeah, I lost track of which buttons these were. It's just the link back to the customized agenda view that needed to be limited. They all needed to be made visible on the personalize tab. Thanks for catching it.
|
This update restores the webcal / .ics buttons to the agenda tab. It relabels them as "filtered agenda" instead of "personal agenda." It also suppresses the duplicate set of buttons at the very end of the agenda tab. On the personalize tab, these are meant to be useful to someone who has gone through the whole page to select individual sessions, but there's little need for them on the agenda tab. |
Fixes test failure caused by ietf-tools#3803.
Fixes test failure caused by ietf-tools#3803.
Fixes #3786 and #3787