Skip to content

feat: persist timeslot types made visible in the schedule editor#3778

Merged
jennifer-richards merged 5 commits into
ietf-tools:feat/bs5from
painless-security:jennifer/persistent-editor-settings-reviewed
Apr 5, 2022
Merged

feat: persist timeslot types made visible in the schedule editor#3778
jennifer-richards merged 5 commits into
ietf-tools:feat/bs5from
painless-security:jennifer/persistent-editor-settings-reviewed

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Fixes #3590

This adds a POST action to the edit_meeting_schedule view that sets a list
of currently visible timeslot types in the user's session. On display of
the schedule editor, this is consulted before defaulting to show only 'regular'
timeslots. An ajax request is made to update the session when changing the
settings in the editor.
…or-settings

feat: persist timeslot types made visible in the schedule editor
@codecov

codecov Bot commented Apr 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3778 (35502cb) into feat/bs5 (8bd4851) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           feat/bs5    #3778   +/-   ##
=========================================
  Coverage     87.97%   87.97%           
=========================================
  Files           296      296           
  Lines         38795    38804    +9     
=========================================
+ Hits          34130    34138    +8     
- Misses         4665     4666    +1     
Impacted Files Coverage Δ
ietf/meeting/views.py 90.74% <100.00%> (+0.03%) ⬆️
ietf/utils/pipe.py 83.33% <0.00%> (-4.17%) ⬇️
ietf/submit/forms.py 82.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2859c43...35502cb. Read the comment docs.

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that his introduces a schema change, so unless we also work it back into main, it wouldn't be possible to revert to (pre-bs5-merge) main in a crunch. It may not be worth the effort to do so, but choosing not to do so makes this the point where we close the door on the possibility.

@rjsparks

rjsparks commented Apr 2, 2022

Copy link
Copy Markdown
Member

(Yes, rolling back the migrations are supposed to be enough, but...)

@rjsparks

rjsparks commented Apr 3, 2022

Copy link
Copy Markdown
Member

and of course, those comments would be better attached to #3777

@jennifer-richards
jennifer-richards merged commit 016ee71 into ietf-tools:feat/bs5 Apr 5, 2022
@jennifer-richards
jennifer-richards deleted the jennifer/persistent-editor-settings-reviewed branch April 5, 2022 19:01
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants