fix: restore function of unassigned review management page#3774
Merged
jennifer-richards merged 5 commits intoApr 1, 2022
Merged
Conversation
jennifer-richards
marked this pull request as draft
March 31, 2022 12:51
Member
Author
|
Converting to draft while I fix the failing test. |
jennifer-richards
marked this pull request as ready for review
March 31, 2022 13:02
Member
Author
|
I think that must have been a spurious failure. I don't see it locally and don't see how this change could have affected it. |
rjsparks
approved these changes
Apr 1, 2022
rjsparks
left a comment
rjsparks
left a comment
Member
There was a problem hiding this comment.
I think we still need to work on the form layout, but this is so much better than what we had
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ietf-tools#3685
N.B., the first three commits are just refactoring/StandardJS-ifying the affected javascript module. Latter two commits have the interesting changes.