Skip to content

ci: Add vnu to dev docker image - #3724

Merged
NGPixel merged 2 commits into
ietf-tools:feat/bs5from
larseggert:vnu-for-dev-image
Mar 22, 2022
Merged

ci: Add vnu to dev docker image#3724
NGPixel merged 2 commits into
ietf-tools:feat/bs5from
larseggert:vnu-for-dev-image

Conversation

@larseggert

Copy link
Copy Markdown
Collaborator

No description provided.

@larseggert

Copy link
Copy Markdown
Collaborator Author

Whoops - why is the diff so huge?

@NGPixel
NGPixel self-requested a review March 22, 2022 10:36
@rjsparks

Copy link
Copy Markdown
Member

This currently assumes an x86 architecture on the developer's machine.

@larseggert

Copy link
Copy Markdown
Collaborator Author

Oh. Yes. The alternate way to do this is to install the JDK from apt and then just pull the JAR. Will do that.

@NGPixel

NGPixel commented Mar 22, 2022

Copy link
Copy Markdown
Member

Whoops - why is the diff so huge?

The original file was incorrectly created using CRLF instead of just LF (thanks Windows). So this is ok.

@NGPixel
NGPixel merged commit f516f86 into ietf-tools:feat/bs5 Mar 22, 2022
@larseggert
larseggert deleted the vnu-for-dev-image branch March 23, 2022 10:16
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants