test: scroll swap timeslots button into view before clicking - #3719
Merged
rjsparks merged 1 commit intoMar 22, 2022
Merged
Conversation
larseggert
reviewed
Mar 22, 2022
Comment on lines
+481
to
+485
| self.driver.execute_script( | ||
| 'window.scrollBy({top: %s, behavior: "instant"})' % ( | ||
| future_swap_days_buttons[1].location['y'] - navbar.size['height'] | ||
| ) | ||
| ) |
Collaborator
There was a problem hiding this comment.
Does self.scroll_to_element not work?
Member
Author
There was a problem hiding this comment.
No, unfortunately. I think that only scrolls until the element is in the viewport. The session panel is still floating over it, intercepting clicks.
(Sorry to repeat, but this showed up as a top level comment rather than a reply to your question)
rjsparks
approved these changes
Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3718