fix: add more explanations in BoF requests#3706
Merged
rjsparks merged 4 commits intoApr 7, 2022
Merged
Conversation
rjsparks
reviewed
Mar 20, 2022
rjsparks
requested changes
Mar 20, 2022
rjsparks
left a comment
Member
There was a problem hiding this comment.
Per offline discussion with éric, he wants to make some changes before this is merged.
Member
NGPixel
marked this pull request as draft
March 21, 2022 18:13
evyncke
force-pushed
the
fix-3517-more-explanation-in-bof-request
branch
from
April 7, 2022 12:27
9a303da to
0daf6cf
Compare
Codecov Report
@@ Coverage Diff @@
## feat/bs5 #3706 +/- ##
=========================================
Coverage 87.97% 87.97%
=========================================
Files 296 297 +1
Lines 38795 38804 +9
=========================================
+ Hits 34130 34139 +9
Misses 4665 4665
Continue to review full report at Codecov.
|
evyncke
marked this pull request as ready for review
April 7, 2022 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #3517