Skip to content

fix: add more explanations in BoF requests#3706

Merged
rjsparks merged 4 commits into
ietf-tools:feat/bs5from
evyncke:fix-3517-more-explanation-in-bof-request
Apr 7, 2022
Merged

fix: add more explanations in BoF requests#3706
rjsparks merged 4 commits into
ietf-tools:feat/bs5from
evyncke:fix-3517-more-explanation-in-bof-request

Conversation

@evyncke

@evyncke evyncke commented Mar 20, 2022

Copy link
Copy Markdown
Collaborator

Fixing issue #3517

@evyncke evyncke changed the title Add more explanations in BoF requests fix: add more explanations in BoF requests Mar 20, 2022
Comment thread ietf/templates/doc/bofreq/new_bofreq.html Outdated

@rjsparks rjsparks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per offline discussion with éric, he wants to make some changes before this is merged.

@rjsparks

Copy link
Copy Markdown
Member

@NGPixel
NGPixel marked this pull request as draft March 21, 2022 18:13
@evyncke
evyncke force-pushed the fix-3517-more-explanation-in-bof-request branch from 9a303da to 0daf6cf Compare April 7, 2022 12:27
@codecov

codecov Bot commented Apr 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #3706 (0daf6cf) into feat/bs5 (8bd4851) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0daf6cf differs from pull request most recent head 8142068. Consider uploading reports for the commit 8142068 to get more accurate results

@@            Coverage Diff            @@
##           feat/bs5    #3706   +/-   ##
=========================================
  Coverage     87.97%   87.97%           
=========================================
  Files           296      297    +1     
  Lines         38795    38804    +9     
=========================================
+ Hits          34130    34139    +9     
  Misses         4665     4665           
Impacted Files Coverage Δ
ietf/meeting/models.py 86.08% <ø> (ø)
ietf/meeting/utils.py 90.27% <ø> (-0.29%) ⬇️
ietf/meeting/templatetags/editor_tags.py 100.00% <100.00%> (ø)
ietf/meeting/views.py 90.73% <100.00%> (+0.02%) ⬆️
ietf/submit/forms.py 82.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68684be...8142068. Read the comment docs.

@evyncke
evyncke marked this pull request as ready for review April 7, 2022 18:22
@rjsparks
rjsparks merged commit fd588d6 into ietf-tools:feat/bs5 Apr 7, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
@evyncke
evyncke deleted the fix-3517-more-explanation-in-bof-request branch November 5, 2022 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants