Fix for reviewer table - #3683
Merged
Merged
Conversation
the entries in one line if possible.
larseggert
approved these changes
Mar 19, 2022
Collaborator
|
I approved, but I did point out to Tero that changes like this will make the page unusable on phones. |
rjsparks
approved these changes
Mar 19, 2022
Contributor
Author
|
Lars Eggert writes:
I approved, but I did point out to Tero that changes like this will make the
page unusable on phones.
I disagree on that. The current datatracker reviwers page is
completely usable on phones, only problem is that the dates do not
have nowrap-text class in them, so the phone splits them to three
rows, making the table rows too high. The page will properly scroll
x and y direction so you can see everything just by scroll left and
right.
There is nothing wrong with having page that you need to scroll back
and worth to see completely. Actually with the current page you can
even zoom it out so it will fit on the screen, but of course then the
text is really tiny, but you can still see all the information at one
glance in case you need that.
I hope the new bs5 system does not do the stupid thing that some pages
do, i.e., disable page zooming, and try to fit everything on the
screen. Those pages are usually completely unusable on phone, but
luckily you can usually request a "computer" version of the page, and
get the proper page which you can scroll around and zoom as needed.
(I.e. I tested the current datatracker page on my phone and it works
fine there, I have not tested the sandbox version with phone).
--
***@***.***
|
Member
|
the page at sandbox-ng.ietf.org does not scroll horizontally. It does not render correctly (even before this PR's change) in portrait mode - it has to be viewed in landscape mode. @larseggert - is horizontal scrolling disabled here intentionally? As long as these are done with tables rather than grids, have you considered https://getbootstrap.com/docs/5.0/content/tables/#always-responsive? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the reviewer list so that document name does not span multiple lines. Fixes issue #3680.