fix: Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced - #3651
Merged
Conversation
…t-reviewss until the are announced. Fixes ietf-tools#3639.
Member
|
Why should this gated on the state of the document in any way? |
Collaborator
Author
|
Once the announcement is sent, there is probably not going to be changes. That said, it would be trivial to remove the check related to the state. Notice that many other fields cannot be edited of the conflict-review is in one of the approved states. |
NGPixel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow AD and Secretariat to update the people to notify about conflict-reviews until the are announced. Fixes #3639.