Skip to content

Registration API Update - #3641

Merged
rjsparks merged 8 commits into
ietf-tools:mainfrom
rpcross:reg_api
Jun 16, 2022
Merged

Registration API Update#3641
rjsparks merged 8 commits into
ietf-tools:mainfrom
rpcross:reg_api

Conversation

@rpcross

@rpcross rpcross commented Mar 14, 2022

Copy link
Copy Markdown
Contributor
  • change MeetingRegistration.reg_type field to hold only one type
  • allow multiple MeetingRegistration records per person/meeting
    (one for each reg_type)
  • migrate existing records (meetings 108-113) with multiple reg_type values to multiple records

- change MeetingRegistration.reg_type field to hold only one type
- allow multiple MeetingRegistration records per person/meeting
  (one for each reg_type)
@rjsparks

Copy link
Copy Markdown
Member

We may want consider a feat branch for this that brings the new meeting attendance api in at the same time.

@rjsparks rjsparks self-assigned this Mar 14, 2022
@rjsparks
rjsparks marked this pull request as draft March 21, 2022 19:21

@raya305 raya305 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Duplicate of #

@rpcross
rpcross marked this pull request as ready for review June 16, 2022 19:57
@rjsparks

Copy link
Copy Markdown
Member

Failing test is unrelated.
I suspect I need to update the nomcom eligibility code to be more selective with the MeetingRegistration information after this change - will add a test to verify.

@rjsparks
rjsparks merged commit 698f031 into ietf-tools:main Jun 16, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants