Skip to content

fix: Use fixed lengths for the first three columns of "meta" tables #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 1 commit into from
Mar 14, 2022
Merged

fix: Use fixed lengths for the first three columns of "meta" tables #3637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ietf/static/css/ietf.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,25 @@ pre {
font-size: inherit;
}

// Use fixed lengths for the first three columns of "meta" tables.
table tbody.meta {

th:first-child,
td:first-child {
width: 9em;
}

th:nth-child(2),
td:nth-child(2) {
// text-align: right;
width: 14em;
}

td.edit {
width: 1px; // Make sure it uses as little space as possible
}
}

// Highlight required form field labels with bi-asterisk
.required>label:after {
display: inline-block;
Expand Down
6 changes: 3 additions & 3 deletions ietf/templates/doc/document_bofreq.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
<table class="table table-sm table-borderless">
<tbody class="meta border-top">
<tr>
<th class="col-1">Document</th>
<th class="col-2">Type</th>
<th>Document</th>
<th>Type</th>
<td class="edit"></td>
<td class="col-9">
<td>
{{ doc.get_state.slug|capfirst }} BOF request
{% if snapshot %}<span class="badge bg-warning">Snapshot</span>{% endif %}
</td>
Expand Down
6 changes: 3 additions & 3 deletions ietf/templates/doc/document_charter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@
<table class="table table-sm table-borderless">
<tbody class="meta border-top">
<tr>
<th class="col-1">Document</th>
<th class="col-2">
<th>Document</th>
<th>
{% if doc.get_state_slug != "approved" %}
Proposed charter
{% else %}
Charter
{% endif %}
</th>
<td class="edit"></td>
<th class="col-9">
<th>
{{ group.name }} {{ group.type.name }}
<a href="{{ group.about_url }}">({{ group.acronym }})</a>
{% if snapshot %}<span class="badge bg-warning">Snapshot</span>{% endif %}
Expand Down
6 changes: 3 additions & 3 deletions ietf/templates/doc/document_conflict_review.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
<table class="table table-sm table-borderless mb-3">
<tbody class="meta border-top">
<tr>
<th class="col-1">Document</th>
<th class="col-2">
<th>Document</th>
<th>
{% if doc.get_state_slug not in approved_states %}
Proposed conflict review
{% else %}
Conflict review
{% endif %}
</th>
<td class="edit"></td>
<td class="col-9">
<td>
<a href="{% url "ietf.doc.views_doc.document_main" name=conflictdoc.canonical_name %}">
{% if conflictdoc.get_state_slug == 'rfc' %}
{{ conflictdoc.canonical_name|upper }}
Expand Down
4 changes: 2 additions & 2 deletions ietf/templates/doc/document_material.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
<table class="table table-sm table-borderless">
<tbody class="meta border-top">
<tr>
<th class="col-2">
<th>
{% if doc.meeting_related %}Meeting{% endif %}
{{ doc.type.name }}
</th>
<td></td>
<td class="col-10">
<td>
{% if doc.group %}
{{ doc.group.name }}
<a href="{{ doc.group.about_url }}">({{ doc.group.acronym }})</a>
Expand Down
6 changes: 3 additions & 3 deletions ietf/templates/doc/document_status_change.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
<table class="table table-sm table-borderless">
<tbody class="meta border-top">
<tr>
<th class="col-1">Document</th>
<th class="col-2">
<th>Document</th>
<th>
{% if doc.get_state_slug not in approved_states %}
Proposed status change
{% else %}
Expand All @@ -33,7 +33,7 @@
</a>
{% endif %}
</td>
<th class="col-9">
<th>
{{ doc.title }}
{% if snapshot %}<span class="badge bg-warning">Snapshot</span>{% endif %}
</th>
Expand Down
6 changes: 3 additions & 3 deletions ietf/templates/group/group_about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
<table class="my-3 table table-sm table-borderless">
<tbody class="meta border-top">
<tr>
<th class="col-2">{{ group.type.name }}</th>
<th class="col-3">Name</th>
<th>{{ group.type.name }}</th>
<th>Name</th>
<td class="edit">
{% if can_edit_group %}
<a class="btn btn-primary btn-sm"
href="{% url 'ietf.group.views.edit' acronym=group.acronym field='name' %}">Edit</a>
{% endif %}
</td>
<th class="col-7">{{ group.name }}</th>
<th>{{ group.name }}</th>
</tr>
<tr>
<td></td>
Expand Down