Skip to content

feat: updated boostrap5 work - #3596

Merged
NGPixel merged 116 commits into
ietf-tools:feat/bs5from
painless-security:personal/jennifer/7.45.1.dev0.bootstrap-merge
Mar 8, 2022
Merged

feat: updated boostrap5 work#3596
NGPixel merged 116 commits into
ietf-tools:feat/bs5from
painless-security:personal/jennifer/7.45.1.dev0.bootstrap-merge

Conversation

@jennifer-richards

@jennifer-richards jennifer-richards commented Mar 8, 2022

Copy link
Copy Markdown
Member

Tests pass except for the code coverage, which dropped slightly.

======================================================================
FAIL: code_coverage_test (ietf.utils.test_runner.CoverageTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/src/ietf/utils/test_runner.py", line 392, in code_coverage_test
    checker.stop()
  File "/root/src/ietf/utils/test_runner.py", line 332, in report_test_result
    ( test, test_coverage*100, latest_coverage_version, master_coverage*100, ))
AssertionError: 0.8805695792880259 not greater than or equal to 0.8809691174563656 : The code coverage percentage is now lower (88.06%) than for version 7.46.0 (88.12%)

----------------------------------------------------------------------
Ran 1344 tests in 1037.548s

FAILED (failures=1, skipped=2)

@larseggert
Nuke bootstrap@3.
8b222df 
 - Legacy-Id: 19573
@larseggert
Remove djangobwr and other bower-related things.
dedbc57 
 - Legacy-Id: 19575
@larseggert
Remove some empty files and directories.
66d7faf 
 - Legacy-Id: 19576
@larseggert
Remove more unused assets.
2684253 
 - Legacy-Id: 19577
@larseggert
Add some ignores
869507b 
 - Legacy-Id: 19580
@larseggert
Require django-bootstrap5
2cef8b6 
 - Legacy-Id: 19582
@larseggert
Dump a bunch of stuff from my local branch into svn.
8efa37e 
 - Legacy-Id: 19583
@larseggert
Tweaks for bootstrap5.
3716d4e 
 - Legacy-Id: 19584
@larseggert
No need to suppress bootstrap3 warning anymore.
50cec76 
 - Legacy-Id: 19585
@larseggert
bootstrap3 -> django_bootstrap5
df25650 
Only load the module, no other changes yet.
 - Legacy-Id: 19586
@larseggert
tablesorter -> datatables
39d500d 
https://datatables.net/ has way more features and better support, and bootstrap5
styling.
 - Legacy-Id: 19587
@larseggert
Fix result table.
a8742de 
 - Legacy-Id: 19588
@larseggert
table-condensed -> table-sm
9cf29ba 
 - Legacy-Id: 19589
@larseggert
Add font-awesome 4.
72569dd 
 - Legacy-Id: 19590
@larseggert
Fix timelines
f12bc99 
 - Legacy-Id: 19591
@larseggert
Fix nav-tabs
6b15c3d 
 - Legacy-Id: 19593
@larseggert
Fix sorter-false
e92441b 
 - Legacy-Id: 19594
@larseggert
btn-default -> btn-primary
94b12af 
 - Legacy-Id: 19606
@larseggert
Replace glyphicons with bootstrap-icons.
1d55937 
 - Legacy-Id: 19607
@larseggert
fontawesome -> bootstrap-icons
726b29b 
 - Legacy-Id: 19608
@larseggert
django_bootstrap5 removed button/endbutton tags
288b937 
 - Legacy-Id: 19609
@larseggert
Reindent all templates with djhtml
021ba39 
 - Legacy-Id: 19610
@larseggert
Fix search buttons
7e57e78 
 - Legacy-Id: 19611
@larseggert
Fix list-inline
b06e2a0 
 - Legacy-Id: 19612
@larseggert
pull-right -> float-end
f17a7ed 
 - Legacy-Id: 19613
@larseggert
Table coloring needs table- prefix.
add1dae 
 - Legacy-Id: 19614
@larseggert
Fix revision list
eddc03c 
 - Legacy-Id: 19615
@larseggert
Labels are badges in bs5.
bb5810a 
 - Legacy-Id: 19616
@larseggert
Fix buttonlist
e632cc7 
 - Legacy-Id: 19617
@larseggert
panel -> card
6b7beb1 
 - Legacy-Id: 19618
larseggert and others added 27 commits February 8, 2022 17:29
@larseggert
Hopefully the final check-ins.
bbf088e 
 - Legacy-Id: 19909
@larseggert
Enable select2 for timezone picker.
7a86a1c 
 - Legacy-Id: 19910
@larseggert
Disable various download buttons if there is no agenda yet.
d7ec9e7 
 - Legacy-Id: 19911
@larseggert
Add back noscript warning about disabled js.
02b9720 
 - Legacy-Id: 19912
@larseggert
A bunch more cosmetic fixes.
67ebade 
 - Legacy-Id: 19913
@larseggert
Some more cosmetic tweaks.
1795609 
 - Legacy-Id: 19914
@larseggert
Check the selenium console log for any issues as part of the test suite,
37cb737 
and fix/suppress errors found by that.
 - Legacy-Id: 19916
@jennifer-richards
Merge 7.45.1.dev0 into Bootstrap 5 update branch. Made a first pass a…
6c260a5 
…t reconciling differences.

 - Legacy-Id: 19945
@larseggert
Hopefully fix ietf-tools#3556.
ca167c0 
 - Legacy-Id: 19978
@larseggert
Make the js a bit less noisy and adjust the tests accordingly.
f61ddb4 
 - Legacy-Id: 19979
@larseggert
Fix # 3555.
686f835 
 - Legacy-Id: 19980
@larseggert
Properly URL-encode and -decode a bunch of query parameters.
07e0eb8 
 - Legacy-Id: 19981
@jennifer-richards
Fix failing tests
9d8f4ea 
 - Legacy-Id: 19982
@jennifer-richards
Merged in [19978] from personal/lars/7.40.1.dev0
2610c7c 
Hopefully fix ietf-tools#3556.
 - Legacy-Id: 19983
Note: SVN reference [19978] has been migrated to Git commit ca167c0
@jennifer-richards
Merged in [19979] from 7.40.1.dev0
c5f86b3 
Make the js a bit less noisy and adjust the tests accordingly.
 - Legacy-Id: 19984
Note: SVN reference [19979] has been migrated to Git commit f61ddb4
@jennifer-richards
Merged in [19980] from personal/lars/7.40.1.dev0
1d301f7 
Fix # 3555.
 - Legacy-Id: 19985
Note: SVN reference [19980] has been migrated to Git commit 686f835
@jennifer-richards
Merged from 7.40.1.dev0
077e7e2 
Properly URL-encode and -decode a bunch of query parameters. [from revision 19,981]
 - Legacy-Id: 19986
@jennifer-richards
Reformat and clean up JS to eliminate warnings
5be2774 
 - Legacy-Id: 19989
@jennifer-richards
Merge remote-tracking branch 'origin/main' into personal/jennifer/7.4…
686a915 
…5.1.dev0.bootstrap-merge

# Conflicts:
#	ietf/templates/meeting/session_buttons_include.html
@jennifer-richards
fix: revert invalid line breaks in templates
0ab0994
@jennifer-richards
refactor: improve readability of template logic in document_html.html
d78d024
@jennifer-richards
fix: fix reference to doc.rfc_number in template
dea0b4e
@jennifer-richards
Merge remote-tracking branch 'origin/main' into personal/jennifer/7.4…
3906bbd 
…5.1.dev0.bootstrap-merge

# Conflicts:
#	bootstrap/package.json
#	ietf/templates/meeting/session_buttons_include.html
@jennifer-richards
fix: only add page navigation panel to compatible templates
3d7b267 
Only add right-hand page navigation panel to #content elements that have
the ietf-auto-nav class and test that the base template's DOM is compatible
with the panel.
@jennifer-richards
fix: clean up formatting of login.html template
baa3b29
@jennifer-richards
fix: handle remote_instructions field correctly on interim request form
93d3daa
@jennifer-richards
Merge remote-tracking branch 'origin/main' into personal/jennifer/7.4…
64d6736 
…5.1.dev0.bootstrap-merge

# Conflicts:
#	bootstrap/package-lock.json
#	bootstrap/package.json
#	package-lock.json
#	package.json
@NGPixel
NGPixel merged commit 4ef9f5c into ietf-tools:feat/bs5 Mar 8, 2022
@jennifer-richards
jennifer-richards deleted the personal/jennifer/7.45.1.dev0.bootstrap-merge branch March 9, 2022 16:58
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jennifer-richards @NGPixel @larseggert