feat: plenary attendance by email address API - #11633
Merged
Merged
Conversation
* rename `Registration.attendance_type` to `plenary_attendance_type` * add `plenary_ticket_type` * refactor to ensure consistency, reduce queries, handle bulk requests
Member
Author
|
Tests added |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11633 +/- ##
==========================================
+ Coverage 88.65% 88.73% +0.08%
==========================================
Files 333 337 +4
Lines 44966 45313 +347
==========================================
+ Hits 39866 40210 +344
- Misses 5100 5103 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jennifer-richards
marked this pull request as ready for review
August 25, 2026 18:57
rjsparks
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an API that looks up plenary meeting attendance for a person by email address. Uses any email address (including inactive). Only returns data for meeting 110 onward, where we have modern attendance data. The filtering is intended to agree with the current attendance calculations - if it does not, that is a bug.
Will return attendance type as "onsite" or "remote". Only "student", "week_pass", "one_day", or "unknown" ticket types are returned. I believe these are the only combinations that reflect plenary registration / attendance.
Refactors the
Registration.attendance_typeproperty to work with bulk operations. Adds tests.Eliminates per-row queries in the
proceedings_attendees()view, dropping it from ~ 2000 to 2.A few cases where one person has multiple
Registrations for a single meeting exist. These are represented as multiple entries with the same"meeting"value in the returned list. I.e., each individualRegistrationis resolved to a single attendance type / ticket type, but no attempt to reconcile multipleRegistrationrecords for a single meeting.Output looks like:
{ "attended": [ { "meeting": "110", "attendance_type": "remote", "ticket_type": "unknown" }, { "meeting": "111", "attendance_type": "remote", "ticket_type": "week_pass" }, { "meeting": "112", "attendance_type": "remote", "ticket_type": "unknown" }, { "meeting": "113", "attendance_type": "remote", "ticket_type": "week_pass" }, { "meeting": "114", "attendance_type": "remote", "ticket_type": "week_pass" } ] }