Skip to content

fix: accept std "To" addrs in announcement tool - #11524

Merged
jennifer-richards merged 2 commits into
ietf-tools:mainfrom
jennifer-richards:fix-announce-validation
Aug 14, 2026
Merged

fix: accept std "To" addrs in announcement tool#11524
jennifer-richards merged 2 commits into
ietf-tools:mainfrom
jennifer-richards:fix-announce-validation

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

The "To" dropdown on the secr app announcement tool has known-valid addresses, so do not validate them. The to_custom field is adequately validated by the MultiEmailField for now. Limit custom validation to the cc field.

The entire form needs to be reworked, so this is just a quick fix for the immediate problem(the "To" options in the dropdown are rejected with a confusing error message)

rjsparks
rjsparks previously approved these changes Aug 14, 2026
Some code changes, some test changes.
@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.66%. Comparing base (6fcc7d8) to head (0a9a7db).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11524      +/-   ##
==========================================
+ Coverage   88.59%   88.66%   +0.06%     
==========================================
  Files         333      333              
  Lines       44728    44963     +235     
==========================================
+ Hits        39626    39865     +239     
+ Misses       5102     5098       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jennifer-richards
jennifer-richards merged commit 95edec0 into ietf-tools:main Aug 14, 2026
9 checks passed
@jennifer-richards
jennifer-richards deleted the fix-announce-validation branch August 14, 2026 14:49
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants