fix: accept std "To" addrs in announcement tool - #11524
Merged
jennifer-richards merged 2 commits intoAug 14, 2026
Merged
Conversation
rjsparks
previously approved these changes
Aug 14, 2026
Some code changes, some test changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11524 +/- ##
==========================================
+ Coverage 88.59% 88.66% +0.06%
==========================================
Files 333 333
Lines 44728 44963 +235
==========================================
+ Hits 39626 39865 +239
+ Misses 5102 5098 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "To" dropdown on the secr app announcement tool has known-valid addresses, so do not validate them. The
to_customfield is adequately validated by theMultiEmailFieldfor now. Limit custom validation to theccfield.The entire form needs to be reworked, so this is just a quick fix for the immediate problem(the "To" options in the dropdown are rejected with a confusing error message)