fix: add email validation to secr announcement form#11245
Open
noralmaani wants to merge 4 commits into
Open
Conversation
jennifer-richards
requested changes
Jul 22, 2026
jennifer-richards
left a comment
jennifer-richards
left a comment
Member
There was a problem hiding this comment.
A few more test cases are needed (and if these uncover problems, please fix)
| self.assertEqual(len(outbox), 1) | ||
| self.assertEqual(outbox[0]["subject"], "Test Subject") | ||
| self.assertEqual(outbox[0]["to"], "<phil@example.com>") | ||
| self.assertEqual(outbox[0]["to"], "<phil@example.com>, <lizz@example.com>, <test@example.com>") |
Member
There was a problem hiding this comment.
Should make sure this accepts addresses like no-brackets@example.com and Named Person <named@example.com> as well
| "reply_to": "secretariat@ietf.org", | ||
| "subject": "Test Subject", | ||
| "body": "This is a test.", | ||
| } |
Member
There was a problem hiding this comment.
Also need test cases for
- both the
to_customandccfields are empty (i.e., no addresses at all) to_customfield has a bad list of otherwise valid addresses (e.g.,lizz@example.com; valid_email@example.com)- same, but for
ccfield
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11180