Skip to content

fix: Use 'Working Group' or 'BOF' on session notification messages - #11235

Merged
jennifer-richards merged 1 commit into
ietf-tools:mainfrom
russhousley:fix-11028
Aug 13, 2026
Merged

fix: Use 'Working Group' or 'BOF' on session notification messages#11235
jennifer-richards merged 1 commit into
ietf-tools:mainfrom
russhousley:fix-11028

Conversation

@russhousley

Copy link
Copy Markdown
Collaborator

fix: Use 'Working Group' or 'BOF' on session notification messages (fixes #11028)

@cabo

cabo commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Should this have code for Research Groups?

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.58%. Comparing base (8dbc1bc) to head (dfa4bc0).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11235      +/-   ##
==========================================
+ Coverage   88.52%   88.58%   +0.05%     
==========================================
  Files         334      333       -1     
  Lines       45102    44672     -430     
==========================================
- Hits        39927    39573     -354     
+ Misses       5175     5099      -76     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjsparks

Copy link
Copy Markdown
Member

Should this have code for Research Groups?

Elaborate?

The code already handles research groups.

This PR makes how it handles RG better by changing the template to say "Group" instead of "Working Group" so messages like the one at https://mailarchive.ietf.org/arch/msg/cfrg/pkYDkGimEuhpwTraZUNfryesDhU/ won't say Working Group Name: Crypto Forum - it will say Group Name: Crypto Forum

The the "on behalf of" branch of the code touched already handled RG gracefully, and this doesn't change that.

Having the group type called out in the context of this mail isn't actually needed.

@cabo

cabo commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

The code already handles research groups.

This PR makes how it handles RG better by changing the template to say "Group" instead of "Working Group" so messages like the one at https://mailarchive.ietf.org/arch/msg/cfrg/pkYDkGimEuhpwTraZUNfryesDhU/ won't say Working Group Name: Crypto Forum - it will say Group Name: Crypto Forum

Great, so that dissonance of seeing 'working group" there is gone.

Thank you!

@jennifer-richards
jennifer-richards merged commit 2f370df into ietf-tools:main Aug 13, 2026
9 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BoF scheduling emails identify the group as a Working Group

4 participants