Skip to content

fix: correct sorting in nomcom feedback tables #11016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennifer-richards merged 1 commit into from
Jun 10, 2026
Merged

fix: correct sorting in nomcom feedback tables #11016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ietf/nomcom/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,6 +1640,20 @@ def test_feedback_topic_badges(self):
q = PyQuery(response.content)
self.assertEqual( len(q('.text-bg-success')), 0 )

def test_feedback_index_sort_keys(self):
url = reverse('ietf.nomcom.views.view_feedback', kwargs={'year': self.nc.year()})
login_testing_unauthorized(self, self.member.user.username, url)
provide_private_key_to_test_client(self)
response = self.client.get(url)
self.assertEqual(response.status_code, 200)
q = PyQuery(response.content)
# Feedback count cells must carry a numeric data-sort-number so that
# a "New" badge appearing before the count doesn't corrupt the sort key.
sort_cells = q('td[data-sort-number]')
self.assertTrue(len(sort_cells) > 0)
for cell in sort_cells.items():
self.assertRegex(cell.attr('data-sort-number'), r'^\d+$')

class NewActiveNomComTests(TestCase):

def setUp(self):
Expand Down
4 changes: 2 additions & 2 deletions ietf/templates/nomcom/view_feedback.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ <h3 class="mt-5" id="declined">Declined each nominated position</h3>
</a>
</td>
{% for fbtype_name, fbtype_count, fbtype_newflag in fb_dict.feedback %}
<td>
<td data-sort-number="{{ fbtype_count }}">
{% if fbtype_newflag %}<span class="badge rounded-pill text-bg-success">New</span>{% endif %}
{{ fbtype_count }}
</td>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h2 class="mt-5" id="topics">Feedback related to topics</h2>
</a>
</td>
{% for fbtype_name, fbtype_count, fbtype_newflag in fb_dict.feedback %}
<td>
<td data-sort-number="{{ fbtype_count }}">
{% if fbtype_newflag %}<span class="badge rounded-pill text-bg-success">New</span>{% endif %}
{{ fbtype_count }}
</td>
Expand Down
Loading