Skip to content

fix: consistent counts at proceedings and proceedings/attendees#10935

Open
rjsparks wants to merge 3 commits into
ietf-tools:mainfrom
rjsparks:meeting_attendees
Open

fix: consistent counts at proceedings and proceedings/attendees#10935
rjsparks wants to merge 3 commits into
ietf-tools:mainfrom
rjsparks:meeting_attendees

Conversation

@rjsparks
Copy link
Copy Markdown
Member

@rjsparks rjsparks commented May 26, 2026

This causes proceedings/attendees to show all attendees, not just those for whom the attendance is nomcom qualifying.

It refactors how attendance is calculated for proceedings, proceedings/attendees, and three_of_five_eligible9389

It fixes a bug (that had no consequence of previous nomcom choices) that counted hackathon only attendance towards nomcom eligibility.

I've independently checked that, except for the bug above which affected only two people, the results for three_of_five_eligible9389 remain unchanged for sets of 5 from [110...115] to [121...125].

Claude was used in creating this PR

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.52%. Comparing base (432aa3b) to head (e1a84da).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ietf/meeting/models.py 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10935      +/-   ##
==========================================
+ Coverage   88.51%   88.52%   +0.01%     
==========================================
  Files         332      332              
  Lines       44970    44950      -20     
==========================================
- Hits        39805    39792      -13     
+ Misses       5165     5158       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@rpcross rpcross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible proceedings/attendees/ view inconsistencies.

Comment thread ietf/meeting/views.py Outdated
remote_count = len(remote)
remote_pks = frozenset(p.pk for p in remote)

regs = list(
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here registrations is being calculated separately and differently than stats so the totals may not match the table data. For example stats.onsite (from meeting.get_attendees().online) would include someone who registered onsite, did not checkin, and attended a session (Attended), whereas registrations would not.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - the reconstruction of Registration objects here is overly complicated anyhow. e1a84da makes it wholly dependent on the people returned by get_attendees.

@rjsparks rjsparks requested a review from rpcross May 29, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants