Skip to content

feat: create docevents for adding/removing obs/updates #10898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rudimatz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: create docevents for adding/removing obs/updates #10898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 48 additions & 6 deletions ietf/api/serializers_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,23 +708,65 @@ def update(self, instance, validated_data):
)
)
if updates is not omitted:
RelatedDocument.objects.filter(
stale_updates = RelatedDocument.objects.filter(
source=rfc, relationship_id="updates"
).exclude(target__rfc_number__in=updates).delete()
).exclude(target__rfc_number__in=updates)
for stale in stale_updates:
rfc_events.append(
DocEvent.objects.create(
doc=rfc,
rev=rfc.rev,
type="sync_from_rfc_editor",
by=system_person,
desc=f"Removed updates relationship to {prettify_std_name(stale.target.name)}",
)
)
stale_updates.delete()
for rfc_num in updates:
target = Document.objects.get(rfc_number=rfc_num, type_id="rfc")
RelatedDocument.objects.get_or_create(
_, created = RelatedDocument.objects.get_or_create(
source=rfc, relationship_id="updates", target=target
)
if created:
rfc_events.append(
DocEvent.objects.create(
doc=rfc,
rev=rfc.rev,
type="sync_from_rfc_editor",
by=system_person,
desc=f"Added updates relationship to {prettify_std_name(target.name)}",
)
)
if obsoletes is not omitted:
RelatedDocument.objects.filter(
stale_obsoletes = RelatedDocument.objects.filter(
source=rfc, relationship_id="obs"
).exclude(target__rfc_number__in=obsoletes).delete()
).exclude(target__rfc_number__in=obsoletes)
for stale in stale_obsoletes:
rfc_events.append(
DocEvent.objects.create(
doc=rfc,
rev=rfc.rev,
type="sync_from_rfc_editor",
by=system_person,
desc=f"Removed obsoletes relationship to {prettify_std_name(stale.target.name)}",
)
)
stale_obsoletes.delete()
for rfc_num in obsoletes:
target = Document.objects.get(rfc_number=rfc_num, type_id="rfc")
RelatedDocument.objects.get_or_create(
_, created = RelatedDocument.objects.get_or_create(
source=rfc, relationship_id="obs", target=target
)
if created:
rfc_events.append(
DocEvent.objects.create(
doc=rfc,
rev=rfc.rev,
type="sync_from_rfc_editor",
by=system_person,
desc=f"Added obsoletes relationship to {prettify_std_name(target.name)}",
)
)

# update subseries relations
if subseries is not omitted:
Expand Down
Loading