Skip to content

fix: pkgs via npm, not CDN; alt-drag for zoom#10795

Merged
jennifer-richards merged 1 commit into
ietf-tools:mainfrom
jennifer-richards:chartjs-via-npm
Apr 30, 2026
Merged

fix: pkgs via npm, not CDN; alt-drag for zoom#10795
jennifer-richards merged 1 commit into
ietf-tools:mainfrom
jennifer-richards:chartjs-via-npm

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Install chart.js and other JS dependencies via npm so they can be bundled.

Noticed that the drag + pan config for the stats graphs interacted badly, so added "alt" modifier to the drag-to-zoom action.

@jennifer-richards
jennifer-richards merged commit 65cd4ab into ietf-tools:main Apr 30, 2026
7 checks passed
@jennifer-richards
jennifer-richards deleted the chartjs-via-npm branch April 30, 2026 21:17
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.48%. Comparing base (7f25c28) to head (5a918ae).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10795      +/-   ##
==========================================
- Coverage   88.49%   88.48%   -0.02%     
==========================================
  Files         332      332              
  Lines       44838    44838              
==========================================
- Hits        39679    39673       -6     
- Misses       5159     5165       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants