Skip to content

feat: Check if any files exists before publishing RFC#10782

Merged
jennifer-richards merged 6 commits intoietf-tools:mainfrom
kesara:feat/blob-check
Apr 30, 2026
Merged

feat: Check if any files exists before publishing RFC#10782
jennifer-richards merged 6 commits intoietf-tools:mainfrom
kesara:feat/blob-check

Conversation

@kesara
Copy link
Copy Markdown
Member

@kesara kesara commented Apr 29, 2026

Fixes #10757

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.48%. Comparing base (15b2abd) to head (21bda80).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
ietf/api/views_rpc.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10782      +/-   ##
==========================================
+ Coverage   88.42%   88.48%   +0.06%     
==========================================
  Files         331      332       +1     
  Lines       44557    44838     +281     
==========================================
+ Hits        39399    39676     +277     
- Misses       5158     5162       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Two things (plus a comment inline that is just a comment, not a request for change). See inline for thing one. Thing two: test should cover the "blob-exists" case in addition to the "file-exists" case.

Comment thread ietf/api/tests_views_rpc.py Outdated
Comment thread ietf/api/views_rpc.py Outdated
@kesara kesara changed the title feat: Check if any files exists before publishing RFC feat: Check if any files exists before publishing RFC Apr 30, 2026
@jennifer-richards jennifer-richards merged commit dd6334a into ietf-tools:main Apr 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional checks before publishing

2 participants