feat: Check if any files exists before publishing RFC#10782
Merged
jennifer-richards merged 6 commits intoietf-tools:mainfrom Apr 30, 2026
Merged
feat: Check if any files exists before publishing RFC#10782jennifer-richards merged 6 commits intoietf-tools:mainfrom
jennifer-richards merged 6 commits intoietf-tools:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10782 +/- ##
==========================================
+ Coverage 88.42% 88.48% +0.06%
==========================================
Files 331 332 +1
Lines 44557 44838 +281
==========================================
+ Hits 39399 39676 +277
- Misses 5158 5162 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jennifer-richards
requested changes
Apr 29, 2026
Member
jennifer-richards
left a comment
There was a problem hiding this comment.
Nice! Two things (plus a comment inline that is just a comment, not a request for change). See inline for thing one. Thing two: test should cover the "blob-exists" case in addition to the "file-exists" case.
jennifer-richards
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10757