feat: update typesense search index on rfc pub/update#10575
Merged
jennifer-richards merged 20 commits intoietf-tools:mainfrom Mar 23, 2026
Merged
feat: update typesense search index on rfc pub/update#10575jennifer-richards merged 20 commits intoietf-tools:mainfrom
jennifer-richards merged 20 commits intoietf-tools:mainfrom
Conversation
NGPixel
previously approved these changes
Mar 19, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10575 +/- ##
==========================================
+ Coverage 88.36% 88.39% +0.02%
==========================================
Files 327 328 +1
Lines 44092 44204 +112
==========================================
+ Hits 38964 39073 +109
- Misses 5128 5131 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Mar 23, 2026
Collaborator
|
Should requirements.txt be updated to include the "httpx" module ? |
Member
Author
Yes, since we refer to it we should include it. I think it should be pulled in automatically as a dependency of the typesense package, though, so it shouldn't actually be required for this to work as intended. |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does an
upsert()with data intended to match what the initial JS index build tool generated. Has been tested against a local typesense instance, but have not done a systematic comparison at all.Draft while I work on the tests.Ready to go, I thinkThings to think about for
this orlater work: (edit: I think best to take this as a complete feature and leave these for future improvements)_sanitize_text()method insearchindex.pyis based on the JS treatment of the content field. I don't completely understand the goals, but it would be good to review this for reasonableness.